Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): checking for remote entry type when loading assets #2753

Merged
merged 8 commits into from
Jul 30, 2024
Merged

fix(runtime): checking for remote entry type when loading assets #2753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f3c5003
fix: checking for remote entry type when loading assets
MadaraUchiha-314 Jul 13, 2024
dd69037
chore: add changeset
MadaraUchiha-314 Jul 13, 2024
b0327e7
fix: rebase
MadaraUchiha-314 Jul 20, 2024
f4c1de6
fix: using the lockfile in main
MadaraUchiha-314 Jul 20, 2024
3a3d869
fix: no lockfile changes
MadaraUchiha-314 Jul 20, 2024
6f8646b
Merge branch 'main' into preload-esm-js-assest-bug
MadaraUchiha-314 Jul 23, 2024
06cbe16
Merge branch 'main' into preload-esm-js-assest-bug
MadaraUchiha-314 Jul 23, 2024
1cc0ef7
Merge branch 'main' into preload-esm-js-assest-bug
ScriptedAlchemy Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/big-bulldogs-matter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@module-federation/runtime': patch
---

checking for remote entry type when loading assets
1 change: 1 addition & 0 deletions packages/runtime/src/utils/preload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ export function preloadAssets(
cb: () => {},
attrs: {
fetchpriority: 'high',
type: remoteInfo?.type === 'module' ? 'module' : 'text/javascript',
},
createScriptHook: (url: string) => {
const res = host.loaderHook.lifecycle.createScript.emit({
Expand Down
Loading