Optimize encoders and skip nul fields #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joroKr21
requested review from
CristinaHG,
JannikArndt,
markus1189 and
saeltz
as code owners
saeltz
approved these changes
Jul 8, 2021
|
|
||
| def contramap[B](f: B => A): ScynamoEncoder[B] = value => self.encode(f(value)) | ||
| def contramap[B](f: B => A): ScynamoEncoder[B] = | ||
| ScynamoEncoder.instance(value => self.encode(f(value))) |
There was a problem hiding this comment.
(Nitpicking:) I'm irritated by all these new line breaks. Do you make them on purpose?
There was a problem hiding this comment.
Yes - I find it hard to read such long lines without a break
markus1189
approved these changes
Jul 8, 2021
This was referenced Jul 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add
Contravariantinstances (enable use ofnarrow)Sorry for the big PR 🙈
Fixes #246