Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update endpoint #401

Merged
merged 8 commits into from
Apr 11, 2023
Merged

chore: update endpoint #401

merged 8 commits into from
Apr 11, 2023

Conversation

poppoerika
Copy link
Contributor

@poppoerika poppoerika commented Apr 11, 2023

Attention:

before merging this console branch back into main, we need to
fix how we are encoding/decoding base64 strings. The functions atob and btoa
are deprecated in the node environment, but Buffer does not exist in a browser. There
are a few ways we can handle this.

  1. have some way to determine an isNode() boolean flag
  2. pull these functions out into their respective sdks
  3. maybe some 3rd party library can help?

#402 is the ticket addressing the above.

@poppoerika poppoerika requested a review from bruuuuuuuce April 11, 2023 16:54
Copy link
Contributor

@bruuuuuuuce bruuuuuuuce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the comment in the pr description, can we also add as a comment at the top of the string.ts file.

Also lets make sure this works inside of the console before we merge it.

@poppoerika
Copy link
Contributor Author

Confirmed the preview console is working and merged the PR for the generate api token page.

Copy link
Contributor

@bruuuuuuuce bruuuuuuuce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@poppoerika poppoerika merged commit 0d288f4 into console-mvp Apr 11, 2023
@poppoerika poppoerika deleted the chore/update-endpoint branch April 11, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants