-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update endpoint #401
Conversation
…-nodejs into chore/update-endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, the comment in the pr description, can we also add as a comment at the top of the string.ts
file.
Also lets make sure this works inside of the console before we merge it.
Confirmed the preview console is working and merged the PR for the generate api token page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attention:
before merging this console branch back into main, we need to
fix how we are encoding/decoding base64 strings. The functions
atob
andbtoa
are deprecated in the node environment, but
Buffer
does not exist in a browser. Thereare a few ways we can handle this.
isNode()
boolean flag#402 is the ticket addressing the above.