Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add facet_fields parameter to all Bioentity routes #315

Merged

Conversation

deepakunni3
Copy link
Contributor

@deepakunni3 deepakunni3 commented Aug 29, 2019

@kshefchek This PR basically adds facet_fields parameter to all Bioentity routes.

And when facet_fields is None, the default subject_taxon_label and object_closure is used.
This is to ensure that we don't break any existing implementations that might assume that these fields are faceted. But this default behavior may be removed in a future release.

This PR is related to monarch-initiative/monarch-ui#168

@deepakunni3 deepakunni3 requested a review from kshefchek August 29, 2019 22:17
@deepakunni3
Copy link
Contributor Author

Travis failing due to api.mi.org being down

@kshefchek
Copy link
Contributor

kshefchek commented Aug 29, 2019

I reran the travis tests now that all of our services are stable, but same results. Odd, I had similar logs on my recent PR

@deepakunni3
Copy link
Contributor Author

@kshefchek It looks like a lot of the behave tests are failing, mostly due to change in the data.
Routes that yielded results before now return empty.

Ex: /api/bioentity/publication/PMID:20220848/genotypes should return an association with object being MONARCH:FBgeno426941, but now there are no associations.

Is this expected?

@kshefchek
Copy link
Contributor

This is expected, we removed fly genotypes in this release

@kshefchek kshefchek merged commit b20abd2 into monarch-initiative:master Aug 30, 2019
@deepakunni3
Copy link
Contributor Author

@kshefchek Thanks for merging the PR.

I'll fix the behave tests in a separate PR. I made some assumptions regarding the data which is likely to change from one release to another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants