This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 29
Enhancement/facets #274
Merged
iimpulse
merged 14 commits into
monarch-initiative:master
from
iimpulse:enhancement/facets
Feb 5, 2020
Merged
Enhancement/facets #274
iimpulse
merged 14 commits into
monarch-initiative:master
from
iimpulse:enhancement/facets
Feb 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshefchek
suggested changes
Feb 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing on /disease/MONDO:0007947:
The paging widget appears broken. I'm not able to facet on the variant table, or it's not obvious where I can do this. Also looks like you've decreased the number of rows to 10 per page, which seems fine but wanted to make note of it in case it was unintentional.
There were some merge conflicts here. Currently the scope of the ticket is only to be filter on gene pages not disease pages. @kshefchek |
kshefchek
approved these changes
Feb 4, 2020
monicacecilia
approved these changes
Feb 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Brilliant! I really like the updates with the button to filter taxa, it makes it SO MUCH easier to understand, and it is very explicit about 'where' you can apply it. - striking difference with how it was used before.
- One thing to tweak for future improvements - to warn the user that the 'taxon filter' is reset as soon as you navigate away from the category you are inspecting. For example, if you apply the filter in the 'homolog' tab, then navigate to a different tab, e.g., 'Function,' when you return to 'Homolog,' the filter is gone. Was this intended?
- Approving nonetheless. This is a TON of amazing work. Thanks @iimpulse !!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#168