Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

Enhancement/facets #274

Merged
merged 14 commits into from
Feb 5, 2020
Merged

Conversation

iimpulse
Copy link
Member

@iimpulse iimpulse commented Feb 3, 2020

Copy link
Contributor

@kshefchek kshefchek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing on /disease/MONDO:0007947:

The paging widget appears broken. I'm not able to facet on the variant table, or it's not obvious where I can do this. Also looks like you've decreased the number of rows to 10 per page, which seems fine but wanted to make note of it in case it was unintentional.

@iimpulse
Copy link
Member Author

iimpulse commented Feb 4, 2020

There were some merge conflicts here. Currently the scope of the ticket is only to be filter on gene pages not disease pages. @kshefchek

@kshefchek kshefchek self-requested a review February 4, 2020 23:43
Copy link
Contributor

@monicacecilia monicacecilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Brilliant! I really like the updates with the button to filter taxa, it makes it SO MUCH easier to understand, and it is very explicit about 'where' you can apply it. - striking difference with how it was used before.
  • One thing to tweak for future improvements - to warn the user that the 'taxon filter' is reset as soon as you navigate away from the category you are inspecting. For example, if you apply the filter in the 'homolog' tab, then navigate to a different tab, e.g., 'Function,' when you return to 'Homolog,' the filter is gone. Was this intended?
  • Approving nonetheless. This is a TON of amazing work. Thanks @iimpulse !! :bowtie:

@iimpulse iimpulse merged commit c6998d9 into monarch-initiative:master Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants