Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Synonym sync tests #705

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Bug fix: Synonym sync tests #705

merged 1 commit into from
Nov 22, 2024

Conversation

joeflack4
Copy link
Contributor

@joeflack4 joeflack4 commented Nov 21, 2024

resolved #690

Overview

Needed to change a file name.

Pre-merge checklist

Documentation

Was the documentation added/updated under docs/?

  • Yes
  • No, updates to the docs were not necessary after careful consideration

QC

Was the full pipeline run before submitting this PR using sh run.sh make build-mondo-ingest on this branch (after
docker pull obolibrary/odkfull:dev), and no errors occurred?

  • Yes
  • No, there are no functional (code-related) changes to the pipeline in the PR, so no re-run is necessary

New Packages

Were any new Python packages added?

Were any other non-Python packages added?

PR Review and Conversations Resolved

Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?

  • Yes

- Update: Needed to change a file name
@joeflack4 joeflack4 self-assigned this Nov 21, 2024
@joeflack4 joeflack4 added bug Something isn't working qc / test labels Nov 21, 2024
@joeflack4 joeflack4 linked an issue Nov 21, 2024 that may be closed by this pull request
Copy link
Contributor

@twhetzel twhetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks for catching this!

@joeflack4 joeflack4 merged commit 4156066 into develop Nov 22, 2024
@joeflack4 joeflack4 deleted the bugfix-test-syn-sync branch November 22, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qc / test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix tests: Synonym Sync
2 participants