Fix subclass of sync #8431
Merged
Fix subclass of sync #8431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the syncing was wrong as the method was deleting _all_ subclass of axioms, regardless of whether they were existential restrictions or subclass between names. It took a while to find this solution, but I think it should work: 1. delete _all_ subclass of axioms after 2. backing up all subclass of axioms with existentials 3. backing uo all subclass of axioms without existentials, and then removing evidence from all the mondo ingest primary sources from it.
|
@matentzn does this mean that #8422 should not be merged? The results of running the Synonym Sync pipeline before this change? cc: @sabrinatoro |
twhetzel
approved these changes
Nov 22, 2024
|
I am on the fence - the diff was so large on the data load #8432 that we cannot with all confidence say that, once the bug is fixed, no other issue emerges.. I am fine merging it, but I am also fine waiting, as we are not going to run subclass sync again until the bug is fixed |
|
Ok, sounds like we should merge it then to clear out PRs and make any future updates as needed once the bug in generating the subclass sync data is sorted since as you say the subclass sync will not be run otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the syncing was wrong as the method was deleting all subclass of axioms, regardless of whether they were existential restrictions or subclass between names. It took a while to find this solution, but I think it should work:
I accidentally merged the synonym sync commit with the URL change but this will disappear since #8430 is merged.