🧹 aws fixes; make aws ec2 instance-connect and aws ec2 ssm work #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjeffrey
force-pushed
the
vj/aws-ec2
branch
3 times, most recently
from
652ef18 to
e7264de
Compare
|
the ebs connection is hooked up in here and technically functional but in my testing the setup is being called too many times. i'll work on that today |
czunker
reviewed
Sep 19, 2023
vjeffrey
force-pushed
the
vj/aws-ec2
branch
from
e7264de to
5b6c85c
Compare
vjeffrey
force-pushed
the
vj/aws-ec2
branch
from
5b6c85c to
5400b87
Compare
|
scp the built cnquery to a machine in ec2, |
|
Perhaps, because of: My EC2 instance is running an AL2023 image. |
|
hmm, that looks like the wrong platform info.. |
|
I get the same for ssm connect: Something for a follow-up: #1812 |
|
ah, i think im missing some logic in the detect, looking now |
ill push up the change in a sec |
|
Got EBS scanning working:
And the scan isn't cleaning up afterwards: I had the same problem with the GCP snapshot scanning. I had to call the cleanup explicitly in the |
|
instance connect and ssm are now working well: |
|
ebs scan is working, but the cleanup isn't working well yet ill work on the cleanup in a followup pr |
|
instance-connect is working: But I had problems with the profile. I created a follow-up for this: #1846 |
|
ssm connect is working: But also affected by #1846 |
|
ebs scan is working: |
I added an issue for that, so we can track it: #1847 |
czunker
approved these changes
Sep 22, 2023
| e := Provider{scannerRegionEc2svc: ec2svc} | ||
| found, _ := e.FindRecentSnapshotForVolume(context.Background(), VolumeId{Id: "vol-0c04d709ea3e59096", Region: "us-east-1", Account: "185972265011"}) | ||
| assert.Equal(t, found, true) | ||
| // found, _ = e.FindRecentSnapshotForVolume(context.Background(), VolumeId{Id: "vol-0d5df63d656ac4d9c", Region: "us-east-1", Account: "185972265011"}) |
| return resources.SSMConnectAsset(args, opts) | ||
| case "ebs": | ||
| return resources.EbsConnectAsset(args, opts) | ||
| } |
There was a problem hiding this comment.
Should we throw an error when there is something unexpected in args[1]?
There was a problem hiding this comment.
Ok, just gave it a try:
FTL failed to run query error="cannot connect to asset, no connection info provided"
LGTM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEBUG=1 go run apps/cnquery/cnquery.go shell aws ec2 instance-connect ec2-user@i-01cbf9d3b50b96946 --profile home --region us-east-1DEBUG=1 go run apps/cnquery/cnquery.go shell aws ec2 ssm ec2-user@i-01cbf9d3b50b96946 --profile home --region us-east-1i transferred the ebs stuff over but it's not all hooked up yet, that's coming in the next pr