🐛 Prevent k8s scan panic #1773
Merged
🐛 Prevent k8s scan panic #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When scanning k8s with container image discovery, it paniced. That happened because asset data was missing. Fixes #1749 Signed-off-by: Christian Zunker <[email protected]>
Signed-off-by: Christian Zunker <[email protected]>
czunker
force-pushed
the
christian/k8s_scan_panic
branch
from
b6c5985 to
cb535f1
Compare
|
Working now: |
czunker
commented
Sep 19, 2023
| defaultConnection uint32 = 1 | ||
| DefaultConnectionType = "aws" | ||
| SshConnectionType = "ssh" | ||
| RegistryImageConnectionType = "registry-image" |
There was a problem hiding this comment.
This removal is also part of #1707. But I removed even more here.
I had to fix this here otherwise, the AWS provider would take over the provider for some images.
czunker
commented
Sep 19, 2023
| assetCandidates = append(assetCandidates, inventorySpec.Inventory.Spec.Assets...) | ||
| } else { | ||
| assetCandidates = append(assetCandidates, runtime.Provider.Connection.Asset) | ||
| processedAssets, err := providers.ProcessAssetCandidates(runtime, runtime.Provider.Connection, upstream, "") |
There was a problem hiding this comment.
That's the actual fix to prevent the panic.
Signed-off-by: Christian Zunker <[email protected]>
|
this all seems correct, i just wanna spin it up locally before merging - doing that now |
vjeffrey
approved these changes
Sep 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scanning k8s with container image discovery, it paniced. That happened because asset data was missing.
Fixes #1749