🐛 add compatibility layer for v8 inventory #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlimus
changed the title
The `kind` field was missing to be compatible with the API. Added a layer to translate v9 kind data to the v8 kind enum (which was removed because we no longer have a centralized authority on asset kinds. Signed-off-by: Dominik Richter <[email protected]>
arlimus
changed the title
arlimus
commented
Oct 3, 2023
| // FIXME: Remove this and solve it at its core | ||
| var ids []string | ||
| for _, id := range asset.PlatformIds { | ||
| if strings.HasPrefix(id, "//") { |
There was a problem hiding this comment.
I noticed a bunch of platform IDs that shouldn't be sent up:
There was a problem hiding this comment.
we need to fix these at their core, this is a sanity-check for v8, but it needs to be removed long-term
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
kindfield was missing to be compatible with the API. Added a layer to translate v9 kind data to the v8 kind enum (which was removed because we no longer have a centralized authority on asset kinds.