-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 add compatibility layer for v8 inventory #2053
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
// Copyright (c) Mondoo, Inc. | ||
// SPDX-License-Identifier: BUSL-1.1 | ||
|
||
package inventory | ||
|
||
import "strings" | ||
|
||
func DeprecatedV8CompatAssets(assets []*Asset) { | ||
for i := range assets { | ||
DeprecatedV8CompatAsset(assets[i]) | ||
} | ||
} | ||
|
||
func DeprecatedV8CompatAsset(asset *Asset) { | ||
if asset == nil { | ||
return | ||
} | ||
|
||
if asset.Platform != nil { | ||
asset.Platform.DeprecatedV8Kind = Kind2DeprecatedV8Kind(asset.Platform.Kind) | ||
} | ||
|
||
for i := range asset.Connections { | ||
conn := asset.Connections[i] | ||
conn.Kind = Kind2DeprecatedV8Kind(asset.KindString) | ||
} | ||
|
||
// FIXME: Remove this and solve it at its core | ||
var ids []string | ||
for _, id := range asset.PlatformIds { | ||
if strings.HasPrefix(id, "//") { | ||
ids = append(ids, id) | ||
} | ||
} | ||
asset.PlatformIds = ids | ||
} | ||
|
||
func Kind2DeprecatedV8Kind(kind string) DeprecatedV8_Kind { | ||
switch kind { | ||
case "virtual-machine-image": | ||
return DeprecatedV8_Kind_KIND_VIRTUAL_MACHINE | ||
case "container-image": | ||
return DeprecatedV8_Kind_KIND_CONTAINER_IMAGE | ||
case "code": | ||
return DeprecatedV8_Kind_KIND_CODE | ||
case "package": | ||
return DeprecatedV8_Kind_KIND_PACKAGE | ||
case "virtual-machine": | ||
return DeprecatedV8_Kind_KIND_VIRTUAL_MACHINE | ||
case "container": | ||
return DeprecatedV8_Kind_KIND_CONTAINER | ||
case "process": | ||
return DeprecatedV8_Kind_KIND_PROCESS | ||
case "api": | ||
return DeprecatedV8_Kind_KIND_API | ||
case "bare-metal": | ||
return DeprecatedV8_Kind_KIND_BARE_METAL | ||
case "network": | ||
return DeprecatedV8_Kind_KIND_NETWORK | ||
case "k8s-object": | ||
return DeprecatedV8_Kind_KIND_K8S_OBJECT | ||
case "aws_object": | ||
return DeprecatedV8_Kind_KIND_AWS_OBJECT | ||
case "gcp-object": | ||
return DeprecatedV8_Kind_KIND_GCP_OBJECT | ||
case "azure-object": | ||
return DeprecatedV8_Kind_KIND_AZURE_OBJECT | ||
default: | ||
return DeprecatedV8_Kind_KIND_UNKNOWN | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a bunch of platform IDs that shouldn't be sent up:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to fix these at their core, this is a sanity-check for v8, but it needs to be removed long-term