110823: Taxonomy tagging and PR template update #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustagir
approved these changes
Nov 8, 2023
.github/pull_request_template.md
Outdated
| @@ -11,3 +11,4 @@ Staging - <https://docs-mongodbcom-staging.corp.mongodb.com/drivers/docsworker-x | |||
| - [ ] Did you run a spell-check? | |||
| - [ ] Did you run a grammar-check? | |||
| - [ ] Are all the links working? | |||
| - [ ] Are the facets and meta tags accurate? | |||
There was a problem hiding this comment.
S: instead of assuming that the tags are already there, maybe this question could be phrased as:
"Are there accurate facets and meta tags on the changed pages?"
There was a problem hiding this comment.
Also, perhaps this item could contain a link to the list of accepted values for the different categories
There was a problem hiding this comment.
I'll add a link, but omit "changed pages" since the existing checklist items apply to that context.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - None
Staging - None
Self-Review Checklist