Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

110823: Taxonomy tagging and PR template update #927

Merged
merged 2 commits into from
Nov 9, 2023
Merged

110823: Taxonomy tagging and PR template update #927

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
856acf7
110823: Taxonomy tagging and PR template update
Nov 8, 2023
d998a89
PRR fixes
Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ Staging - <https://docs-mongodbcom-staging.corp.mongodb.com/drivers/docsworker-x
- [ ] Did you run a spell-check?
- [ ] Did you run a grammar-check?
- [ ] Are all the links working?
- [ ] Are the facets and meta tags accurate?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: instead of assuming that the tags are already there, maybe this question could be phrased as:
"Are there accurate facets and meta tags on the changed pages?"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, perhaps this item could contain a link to the list of accepted values for the different categories

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a link, but omit "changed pages" since the existing checklist items apply to that context.

7 changes: 7 additions & 0 deletions source/motor.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@
Motor (Async Driver)
====================

.. facet::
:name: genre
:values: reference

.. meta::
:keywords: Python async, Stable API, local connection, atlas

.. contents:: On this page
:local:
:backlinks: none
Expand Down
Loading