Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metamodel entity changes #51

Merged
merged 10 commits into from
Oct 16, 2024
Merged

Metamodel entity changes #51

merged 10 commits into from
Oct 16, 2024

Conversation

sachintendulkar576123
Copy link
Contributor

@sachintendulkar576123 sachintendulkar576123 commented Oct 15, 2024

Proposed changes

Added Attributes for Span Type Retrieval, Inference:

Added attributes for Retrieval and Inference Span Types.
The format used is:(https://github.com/monocle2ai/monocle/blob/2bae8a1443a1958e701396886c1ee12e4539f6f5/src/monocle_apptrace/metamodel/spans/span_example.json)

Updated wrap_common.py:

Modified the wrap_common.py file to include logic for updating attributes related to span type retrieval and inference.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Signed-off-by: sachintendulkar576123 <[email protected]>
Signed-off-by: sachintendulkar576123 <[email protected]>
Signed-off-by: sachintendulkar576123 <[email protected]>
src/monocle_apptrace/wrap_common.py Outdated Show resolved Hide resolved
@akshay-okahu
Copy link

Could you confirm if test samples update is planned in separate PR

@sachintendulkar576123
Copy link
Contributor Author

Could you confirm if test samples update is planned in separate PR

I have updated testcase in same PR

@oi-raanne oi-raanne requested a review from Hansrajr October 16, 2024 14:04
Signed-off-by: sachintendulkar576123 <[email protected]>
Copy link
Contributor

@Hansrajr Hansrajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@oi-raanne oi-raanne merged commit 850dfef into monocle2ai:main Oct 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants