-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metamodel entity changes #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sachintendulkar576123 <[email protected]>
Signed-off-by: sachintendulkar576123 <[email protected]>
Signed-off-by: sachintendulkar576123 <[email protected]>
oi-raanne
reviewed
Oct 16, 2024
oi-raanne
reviewed
Oct 16, 2024
src/monocle_apptrace/metamodel/maps/attributes/inference/lang_chain_entities.json
Outdated
Show resolved
Hide resolved
oi-raanne
requested review from
kshitiz-okahu,
prasad-okahu,
akshay-okahu and
anshul7665
October 16, 2024 05:48
Hansrajr
suggested changes
Oct 16, 2024
oi-raanne
reviewed
Oct 16, 2024
src/monocle_apptrace/metamodel/maps/attributes/retrieval/lang_chain_entities.json
Outdated
Show resolved
Hide resolved
src/monocle_apptrace/metamodel/maps/attributes/retrieval/llama_index_entities.json
Outdated
Show resolved
Hide resolved
src/monocle_apptrace/metamodel/maps/attributes/inference/lang_chain_entities.json
Outdated
Show resolved
Hide resolved
Could you confirm if test samples update is planned in separate PR |
Signed-off-by: sachintendulkar576123 <[email protected]>
oi-raanne
reviewed
Oct 16, 2024
Signed-off-by: sachintendulkar576123 <[email protected]>
Signed-off-by: sachintendulkar576123 <[email protected]>
Signed-off-by: sachintendulkar576123 <[email protected]>
oi-raanne
approved these changes
Oct 16, 2024
I have updated testcase in same PR |
akshay-okahu
approved these changes
Oct 16, 2024
Signed-off-by: sachintendulkar576123 <[email protected]>
Hansrajr
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Hansrajr
approved these changes
Oct 16, 2024
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added Attributes for Span Type Retrieval, Inference:
Added attributes for Retrieval and Inference Span Types.
The format used is:(https://github.com/monocle2ai/monocle/blob/2bae8a1443a1958e701396886c1ee12e4539f6f5/src/monocle_apptrace/metamodel/spans/span_example.json)
Updated wrap_common.py:
Modified the wrap_common.py file to include logic for updating attributes related to span type retrieval and inference.
Types of changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...