Major updates #34
Merged
Major updates #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 15, 2024
Closed
Closed
rdmorin
requested changes
Mar 15, 2024
| #' @param bin_df Data frame with bins. | ||
| #' @param min_value Minimum value to retain the bin. | ||
| #' @param filename Path to a local file on drive to save the resulting file. | ||
| #' |
There was a problem hiding this comment.
Maybe we should say "nothing" for the return or (better yet) make functions like this one return the "full path to the file that was written"
There was a problem hiding this comment.
Agree, added this to this function and other similar functions that were writing files
R/cache_output.R
Outdated
| #' @param function_params TODO. | ||
| #' @param additional_details TODO. | ||
| #' | ||
| #' @return file |
There was a problem hiding this comment.
see earlier comment regarding what to return
| @@ -31,7 +31,7 @@ | |||
| #' maf1, | |||
| #' regions_bed = grch37_ashm_regions | |||
| #' ) | |||
| #' #' calculate_tmb( | |||
| #' calculate_tmb( | |||
There was a problem hiding this comment.
The title of this function should probably be "calculate tumour mutation burden", to be more intuitive and self-explanatory
There was a problem hiding this comment.
Thanks - Updated the title!
rdmorin
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the following issues: