Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit fixes #85

Merged
merged 12 commits into from
Oct 31, 2024
Merged

Audit fixes #85

merged 12 commits into from
Oct 31, 2024

Conversation

peyha
Copy link
Collaborator

@peyha peyha commented Oct 18, 2024 •
edited
Loading

Fixes for the Cantina audit:

  • preLCF & preLIF refactor related to this finding
  • Readme update to present the "close factor exploit" (mentioned in the audit as the iterative pre-liquidation) related to this finding
  • Wrote a short disclaimer about the used solidity version 0.8.27 after this finding

Fixes for the ABDK audit:

  • preLCF & preLIF refactor
  • Solidity version update in ErrorsLib.sol

@peyha peyha changed the title Fix for the Spearbit audit Fix for the Cantina audit Oct 18, 2024
MathisGD
MathisGD reviewed Oct 18, 2024
View reviewed changes
colin-morpho
colin-morpho reviewed Oct 18, 2024
View reviewed changes
colin-morpho
colin-morpho reviewed Oct 18, 2024
View reviewed changes
colin-morpho
colin-morpho previously approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@colin-morpho colin-morpho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments on the README.

colin-morpho
colin-morpho requested changes Oct 18, 2024
View reviewed changes
colin-morpho
colin-morpho reviewed Oct 18, 2024
View reviewed changes
QGarchery
QGarchery previously approved these changes Oct 18, 2024
View reviewed changes
QGarchery
QGarchery previously approved these changes Oct 21, 2024
View reviewed changes
@MathisGD MathisGD mentioned this pull request Oct 21, 2024
Closed
MathisGD
MathisGD previously approved these changes Oct 21, 2024
View reviewed changes
QGarchery
QGarchery previously approved these changes Oct 21, 2024
View reviewed changes
@MathisGD MathisGD requested a review from colin-morpho October 21, 2024 10:07
@MathisGD MathisGD changed the title Fix for the Cantina audit Audit fixes Oct 21, 2024
colin-morpho
colin-morpho previously approved these changes Oct 21, 2024
View reviewed changes
@peyha peyha dismissed stale reviews from colin-morpho, QGarchery, and MathisGD via 30eeb67 October 24, 2024 09:17
MathisGD
MathisGD previously approved these changes Oct 24, 2024
View reviewed changes
colin-morpho
colin-morpho reviewed Oct 24, 2024
View reviewed changes
@MathisGD MathisGD merged commit 3d5a1be into main Oct 31, 2024
4 checks passed
@MathisGD MathisGD deleted the fix/cantina branch October 31, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-morpho colin-morpho colin-morpho left review comments

@QGarchery QGarchery QGarchery approved these changes

@MathisGD MathisGD MathisGD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peyha @QGarchery @MathisGD @colin-morpho