[MOSIO-34112] Adding test cases #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khuddus shariff <[email protected]>
Signed-off-by: khuddus shariff <[email protected]>
Comment on lines
907
to
908
| assertFalse(messageDto.getIsValid()); | ||
| assertTrue(messageDto.getInternalError()); |
There was a problem hiding this comment.
We should use the ArgumentCaptor as well
Comment on lines
939
to
940
| assertFalse(messageDto.getIsValid()); | ||
| assertTrue(messageDto.getInternalError()); |
There was a problem hiding this comment.
We should use the ArgumentCaptor as well
Comment on lines
958
to
959
| matchedRidList.add("27847657360002520190320095011"); | ||
| matchedRidList.add("27847657360002520190320095011"); |
Comment on lines
967
to
968
| assertFalse(messageDto.getIsValid()); | ||
| assertTrue(messageDto.getInternalError()); |
There was a problem hiding this comment.
We should use the ArgumentCaptor as well
Comment on lines
996
to
997
| assertFalse(messageDto.getIsValid()); | ||
| assertTrue(messageDto.getInternalError()); |
There was a problem hiding this comment.
We should use the ArgumentCaptor as well
Comment on lines
1025
to
1027
| MessageDTO messageDto = bioDedupeProcessor.process(dto, stageName); | ||
| assertFalse(messageDto.getIsValid()); | ||
| assertTrue(messageDto.getInternalError()); |
There was a problem hiding this comment.
We should use the ArgumentCaptor as well
Comment on lines
-188
to
-190
|
|
||
| } | ||
|
|
| @@ -450,11 +456,11 @@ public void testBioDeDupUpdatePacketHandlerProcessingSuccess() throws ApisResour | |||
| * @throws RegistrationProcessorCheckedException | |||
| */ | |||
| @Test | |||
| @Ignore | |||
There was a problem hiding this comment.
Shall we remove this test case or just keep @ignore annotation.
| // One match of RID/AID found at bio dedupe, | ||
| // but UIN of the duplicate match is different from update packet UIN when AutoReject is True | ||
| @Test | ||
| public void oneMatchFoundWithDiffrentUinWithMatchAutoRejecAsTrue() throws ApisResourceAccessException, IOException, |
There was a problem hiding this comment.
Correct the typo mistake Diffrent -> Different. Check other places as well.
| public void oneMatchFoundWithDiffrentUinWithMatchAutoRejecAsTrue() throws ApisResourceAccessException, IOException, | ||
| PacketDecryptionFailureException, io.mosip.kernel.core.exception.IOException, JsonProcessingException, PacketManagerException { | ||
| registrationStatusDto.setRegistrationId("27847657360002520190320095011"); | ||
| registrationStatusDto.setRegistrationType("UPDATE"); |
There was a problem hiding this comment.
Add the below for currently processing RID.
registrationStatusDto.setStatusCode("PROCESSING");
Check other occurrences as well.
Signed-off-by: khuddus shariff <[email protected]>
Signed-off-by: khuddus shariff <[email protected]>
Signed-off-by: khuddus shariff <[email protected]>
Signed-off-by: khuddus shariff <[email protected]>
|
Code reviewed. |
vishwa-vyom
approved these changes
Jul 26, 2024
Khuddusshariff0022
added a commit
to Khuddusshariff0022/registration
that referenced
this pull request
Aug 1, 2024
* [MOSIO-34112] Adding test cases Signed-off-by: khuddus shariff <[email protected]> --------- Signed-off-by: khuddus shariff <[email protected]>
vishwa-vyom
pushed a commit
that referenced
this pull request
Aug 4, 2024
…#1901) * [MOSIO-34112] Adding test cases (#1899) * [MOSIO-34112] Adding test cases Signed-off-by: khuddus shariff <[email protected]> --------- Signed-off-by: khuddus shariff <[email protected]> * pushtriger changes Signed-off-by: khuddus shariff <[email protected]> * added logger Signed-off-by: khuddus shariff <[email protected]> * test case modification Signed-off-by: khuddus shariff <[email protected]> * test case modification commented changes Signed-off-by: khuddus shariff <[email protected]> * test case modification commented changes Signed-off-by: khuddus shariff <[email protected]> --------- Signed-off-by: Sowmya Ujjappa Banakar <[email protected]> Signed-off-by: khuddus shariff <[email protected]> Co-authored-by: Sowmya Ujjappa Banakar <[email protected]> Co-authored-by: Sowmya Ujjappa Banakar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.