Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOSIO-34112] Adding test cases #1899

Merged
merged 6 commits into from
Jul 26, 2024
+322 −15
Merged

[MOSIO-34112] Adding test cases #1899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
96e4d6a
[MOSIO-34112] Adding test cases
Khuddusshariff0022 Jul 23, 2024
b0fb466
[Mosip-34112] resolving PR comment
Khuddusshariff0022 Jul 25, 2024
56bacc3
[Mosip-34112] resolving PR comment-1
Khuddusshariff0022 Jul 26, 2024
2f0aaee
[Mosip-34112] resolving PR comment
Khuddusshariff0022 Jul 26, 2024
57073a3
[Mosip-34112] resolving PR comment
Khuddusshariff0022 Jul 26, 2024
bb99226
[Mosip-34112] resolving PR comment
Khuddusshariff0022 Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...src/main/java/io/mosip/registration/processor/biodedupe/constants/BioDedupeConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public class BioDedupeConstants {
/** The Constant INTERNAL_ERROR. */
private static final String INTERNAL_ERROR = "Internal error occurred in bio-dedupe stage while processing for registrationId ";

public static final String ABIS_RESPONSE_MATCHING = "ABIS response Details matching, destination stage is UIN";
public static final String BIOMETRIC_MATCH_FOUND_WITH_SELF = "Biometric match found successfully, destination stage is UIN";

public static final String NO_MATCH_FOUND_FOR_UPDATE = "No match found, rejecting the Update packet for ";
}
public static final String BIOMETRIC_MATCH_FOUND_WITH_OTHER = "Biometric match found with other user, rejecting packet for ";
}
15 changes: 6 additions & 9 deletions ...age/src/main/java/io/mosip/registration/processor/biodedupe/stage/BioDedupeProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,7 @@ public MessageDTO process(MessageDTO object, String stageName) {
newPacketPreAbisIdentification(registrationStatusDto, object);
} else if (packetStatus.equalsIgnoreCase(AbisConstant.POST_ABIS_IDENTIFICATION)) {
postAbisIdentification(registrationStatusDto, object, registrationType);

}

Comment on lines -188 to -190
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these extra changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

} else if (registrationType.equalsIgnoreCase(SyncTypeDto.UPDATE.toString())
|| registrationType.equalsIgnoreCase(SyncTypeDto.RES_UPDATE.toString())) {
String packetStatus = abisHandlerUtil.getPacketStatus(registrationStatusDto);
Expand Down Expand Up @@ -444,9 +442,8 @@ private void postAbisIdentification(InternalRegistrationStatusDto registrationSt
updatePostAbisIdentification(registrationStatusDto, object, registrationType, moduleName,
matchedRegIds);
}else {
sendToManualAdjudicationStage(registrationStatusDto, object, registrationType, moduleName, matchedRegIds);

regProcLogger.info(LoggerFileConstant.SESSIONID.toString(), LoggerFileConstant.REGISTRATIONID.toString(),
sendToManualAdjudicationStage(registrationStatusDto, object, registrationType, moduleName, matchedRegIds);
regProcLogger.info(LoggerFileConstant.SESSIONID.toString(), LoggerFileConstant.REGISTRATIONID.toString(),
registrationStatusDto.getRegistrationId(), BioDedupeConstants.ABIS_RESPONSE_NOT_NULL);
}
}
Expand Down Expand Up @@ -489,21 +486,21 @@ private void updatePostAbisIdentification(InternalRegistrationStatusDto registra
registrationStatusDto.setSubStatusCode(StatusUtil.BIO_DEDUPE_SUCCESS.getCode());
regProcLogger.info(LoggerFileConstant.SESSIONID.toString(),
LoggerFileConstant.REGISTRATIONID.toString(), registrationStatusDto.getRegistrationId(),
BioDedupeConstants.ABIS_RESPONSE_MATCHING);
BioDedupeConstants.BIOMETRIC_MATCH_FOUND_WITH_SELF);
} else {
if (biometricsUpdateSingleMatchAutoReject) {
registrationStatusDto.setLatestTransactionStatusCode(
RegistrationTransactionStatusCode.FAILED.toString());
object.setIsValid(Boolean.FALSE);
registrationStatusDto.setStatusCode(RegistrationStatusCode.REJECTED.name());
registrationStatusDto
.setStatusComment(StatusUtil.UPDATE_PACKET_BIOMETRICS_NO_MATCH_FOUND.getMessage());
.setStatusComment(StatusUtil. UPDATE_PACKET_BIOMETRICS_MATCHED_WITH_OTHER.getMessage());
registrationStatusDto
.setSubStatusCode(StatusUtil.UPDATE_PACKET_BIOMETRICS_NO_MATCH_FOUND.getCode());
.setSubStatusCode(StatusUtil. UPDATE_PACKET_BIOMETRICS_MATCHED_WITH_OTHER.getCode());
regProcLogger.info(LoggerFileConstant.SESSIONID.toString(),
LoggerFileConstant.REGISTRATIONID.toString(),
registrationStatusDto.getRegistrationId(),
BioDedupeConstants.NO_MATCH_FOUND_FOR_UPDATE
BioDedupeConstants.BIOMETRIC_MATCH_FOUND_WITH_OTHER
+ registrationStatusDto.getRegistrationId());
} else {
sendToManualAdjudicationStage(registrationStatusDto, object, registrationType, moduleName,
Expand Down
Loading
Loading