Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ros2 control usage #192

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Update ros2 control usage #192

merged 2 commits into from
Dec 20, 2023

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Dec 19, 2023

Addresses these deprecation warnings

[Deprecated] Passing the robot description parameter directly to the control_manager node is deprecated. Use '~/robot_description' topic from 'robot_state_publisher' instead.

and

Parsing of optional initial interface values failed or uses a deprecated format. Add initial values for every state interface in the ros2_control.xacro. For example:
[ros2_control_node-5] <state_interface name="velocity">
[ros2_control_node-5]   <param name="initial_value">0.0</param>
[ros2_control_node-5] </state_interface>

@sjahr sjahr requested review from sea-bass and Abishalini December 19, 2023 18:01
@sjahr sjahr force-pushed the pr-update_ros2_control branch from 610f4bd to 779724f Compare December 19, 2023 18:13
@sjahr sjahr force-pushed the pr-update_ros2_control branch from 0f97872 to ad665bd Compare December 20, 2023 08:29
@sjahr sjahr requested a review from sea-bass December 20, 2023 08:32
@sjahr sjahr merged commit 17e7423 into moveit:ros2 Dec 20, 2023
5 checks passed
sjahr added a commit to sjahr/moveit_resources that referenced this pull request Dec 21, 2023
@sjahr
Update ros2 control usage (moveit#192)
b9a64c8 
* Update ros2_control usage

* Update dual_arm_panda_moveit_config/config/panda_hand.ros2_control.xacro

Co-authored-by: Sebastian Castro <[email protected]>

---------

Co-authored-by: Sebastian Castro <[email protected]>
# Conflicts:
#	dual_arm_panda_moveit_config/config/panda.ros2_control.xacro
#	dual_arm_panda_moveit_config/config/panda_hand.ros2_control.xacro
#	dual_arm_panda_moveit_config/launch/demo.launch.py
sea-bass pushed a commit that referenced this pull request Dec 21, 2023
@sjahr
Update ros2 control usage (#192) (#193)
df8401d 
* Update ros2_control usage

* Update dual_arm_panda_moveit_config/config/panda_hand.ros2_control.xacro

Co-authored-by: Sebastian Castro <[email protected]>

---------

Co-authored-by: Sebastian Castro <[email protected]>
# Conflicts:
#	dual_arm_panda_moveit_config/config/panda.ros2_control.xacro
#	dual_arm_panda_moveit_config/config/panda_hand.ros2_control.xacro
#	dual_arm_panda_moveit_config/launch/demo.launch.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sea-bass sea-bass sea-bass approved these changes

@Abishalini Abishalini Awaiting requested review from Abishalini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjahr @sea-bass