Refactor MTE-3854 Integrate menu refactor work and xcode 16 #23381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Generated by 🚫 Danger Swift against 609d794 |
clarmso
commented
Nov 25, 2024
| @@ -119,6 +119,7 @@ | |||
| "ShortcutRouteTests\/testOpenLastBookmarkShortcutWithInvalidUrl()", | |||
| "TabManagerTests\/testDeleteSelectedTab()", | |||
| "TabManagerTests\/testPrivatePreference_togglePBMDeletesPrivate()", | |||
| "TabToolbarHelperTests\/testTelemetryForSiteMenu()", | |||
There was a problem hiding this comment.
This test fails with the menu refactor turned on. 😞
|
@isabelrios Should we merge this PR just with the changes for smoke tests? 🙂 Please approve this PR if it's the case. We can address the full functional tests in a subsequent PR. |
|
This pull request has conflicts when rebasing. Could you fix it @clarmso? 🙏 |
mdotb-moz
force-pushed
the
cs/MTE-3854-menu-refactor-xcode-16
branch
from
b2c6b6a
to
373343b
Compare
mdotb-moz
had a problem deploying
to
github-pages
GitHub Actions
Failure
…dressPAM in the screen graph)
mdotb-moz
force-pushed
the
cs/MTE-3854-menu-refactor-xcode-16
branch
from
334372c
to
f8c6e01
Compare
isabelrios
reviewed
Nov 28, 2024
| XCUIDevice.shared.orientation = .landscapeLeft | ||
| mozWaitForElementToExist(hamburgerMenu) | ||
| mozWaitForElementToNotExist(app.tables["Context Menu"]) | ||
| // mozWaitForElementToNotExist(app.tables["Context Menu"]) |
There was a problem hiding this comment.
can we add a comment why we comment these lines?
isabelrios
reviewed
Nov 28, 2024
| @@ -58,25 +61,25 @@ class ToolbarMenuTests: BaseTestCase { | |||
| "Menu button is not below the pocket cells area" | |||
| ) | |||
| hamburgerMenu.tap() | |||
| mozWaitForElementToExist(app.tables["Context Menu"]) | |||
| mozWaitForElementToExist(app.images[StandardImageIdentifiers.Large.avatarCircle]) | |||
| // mozWaitForElementToExist(app.tables["Context Menu"]) | |||
clarmso
commented
Nov 28, 2024
| [ | ||
| app.staticTexts["mozilla.org"], | ||
| app.staticTexts["Secure connection"] | ||
| ] |
There was a problem hiding this comment.
Please do not change the indentation (unless it's swiftlint related).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
💡 Description
Cherry pick menu refactor work after Xcode 16 is in use.
TODO
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)