Bugfix FXIOS-10727 [BookmarkDetails] TextField keyboard dismissed when tap on outside in AddNewBookmarks #23433
Conversation
gokulvenkat243
changed the title
thatswinnie
changed the title
There was a problem hiding this comment.
Could you please enter the details for the description and check the boxes in the checklist for the tasks done with this PR. I also noticed that you didn't update the Jira and Github links so I fixed that as well as update the PR title.
For any future PRs could you please fill out all the details in the PR template and name the PR according to our naming guidelines?
| @@ -333,6 +334,18 @@ class LegacyBookmarkDetailPanel: SiteTableViewController, BookmarksRefactorFeatu | |||
| return url?.schemeIsValid == true && url?.host != nil | |||
| } | |||
|
|
|||
| private func dismissKeyBoardWhenTapOnOutsideTapGesture() { | |||
There was a problem hiding this comment.
Thanks so much for this fix @gokulvenkat243 🙏🏼
Do you think you could rename this method to addDismissKeyboardGesture()? The current name sounds more like the action executed when the gesture is activated.
There was a problem hiding this comment.
I fixed that.
Client.app: Coverage: 31.63
Generated by 🚫 Danger Swift against a528fcb |
📜 Tickets
Jira ticket
Github issue
💡 Description
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)This PR solved the textfield keyboard are dismissed when tap on outside view in AddNewBookmarks(LegacyBookmarkDetailsPanel)