Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-10727 [BookmarkDetails] TextField keyboard dismissed when tap on outside in AddNewBookmarks #23433

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Bugfix FXIOS-10727 [BookmarkDetails] TextField keyboard dismissed when tap on outside in AddNewBookmarks #23433

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c8decc
Dismiss keyboard when tap on outside in LegacyBookmarkDetailsPanel
gokulvenkat243 Nov 27, 2024
a528fcb
renamed function name
gokulvenkat243 Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions firefox-ios/Client/Frontend/Library/Bookmarks/Legacy/LegacyBookmarkDetailPanel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ class LegacyBookmarkDetailPanel: SiteTableViewController, BookmarksRefactorFeatu
}

updateSaveButton()
addDismissKeyboardGesture()
}

override func viewDidAppear(_ animated: Bool) {
Expand Down Expand Up @@ -333,6 +334,18 @@ class LegacyBookmarkDetailPanel: SiteTableViewController, BookmarksRefactorFeatu
return url?.schemeIsValid == true && url?.host != nil
}

private func addDismissKeyboardGesture() {
let tapGesture = UITapGestureRecognizer(target: self, action: #selector(dismissTextFieldKeyboard))
tapGesture.cancelsTouchesInView = false
view.addGestureRecognizer(tapGesture)
}

// dismiss textField keyboard when tap on the outside view
@objc
private func dismissTextFieldKeyboard() {
view.endEditing(true)
}

// MARK: - Button Actions
func topRightButtonAction() {
save().uponQueue(.main) { _ in
Expand Down