Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ergonomic improvements for querying #186

Merged
merged 9 commits into from
Oct 21, 2024
Merged

Ergonomic improvements for querying #186

merged 9 commits into from
Oct 21, 2024

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Oct 18, 2024

As discussed by Jeff in #156 and elsewhere (#154, offline), it is hard to know what to put into functions that might interact with metadata on remotes. This PR starts the process of improving this.

  • If the user specifies a location (non-NULL argument location), then allow_remote should default to TRUE. I've implemented this by changing the advertised default to NULL and evaluating it after seeing what we were given for location.
  • The arguments to compose a query (expr, name, etc) would be useful on user-facing functions for autocomplete etc. Otherwise they are several levels of man page away and really quite hard to find

The improvements continue in the more disruptive PR #187

@richfitz richfitz marked this pull request as ready for review October 18, 2024 16:59
@richfitz richfitz requested a review from plietar October 18, 2024 16:59
@M-Kusumgar M-Kusumgar self-requested a review October 21, 2024 12:52
Copy link
Contributor

@M-Kusumgar M-Kusumgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion but yh i think this is in the right direction based on memory of conversation with jeff, the orderly search documentation improvement is also much clearer thanks

R/query_search.R Outdated Show resolved Hide resolved
richfitz and others added 2 commits October 21, 2024 16:35
@richfitz richfitz merged commit e1fccec into main Oct 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants