Ergonomic improvements for querying, part 2 #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richfitz
force-pushed
the
gh-156-2
branch
3 times, most recently
from
4268315 to
83d508f
Compare
M-Kusumgar
approved these changes
Oct 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #156 (mostly) by making the arguments to the whole search system much easier to discover.
All arguments now come through as top-level arguments, with the docs being easier to follow and autocomplete better. Some defaults have been changed to better reflect what is wanted, and in other cases arguments that make no sense have been removed (e.g., if we would always want to include remote locations). The old options interface is supported for now with a deprecation warning