Verify location before addition

[richfitz]

Merge after #185, contains those commits.

This PR adds new arguments verify and quiet to orderly_location_add:

• verify will try and connect to the location before addition, erroring (and therefore making no changes) if it is misconfigured
• quiet uses the same approach as Make pulling metadata more chatty #185 for controlling how chatty we are while we do this

This PR also fixes a small logic error in save_token where we say "Defaults to TRUE if NULL" - this looks to have been lost at some point and it remains as NULL until referenced within if () at which point we threw an error. Now set set save_token to the value of is.null(token)

[codecov]

Codecov Report

Attention: Patch coverage is 96.22642% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.45%. Comparing base (1abea95) to head (713dc52).
Report is 49 commits behind head on main.

Files with missing lines	Patch %	Lines
R/location.R	97.50%	1 Missing ⚠️
R/util.R	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   99.89%   99.45%   -0.44%     
==========================================
  Files          40       41       +1     
  Lines        3746     3680      -66     
==========================================
- Hits         3742     3660      -82     
- Misses          4       20      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[richfitz]

That coverage report from codecov is out of date and not being updated for its own mysterious reasons

[plietar]

I like this, especially since it means it will perform and cache authentication when adding the location, not randomly later on.

I would expect this to do a bit more than just calling authorize(). If you hit the root of the API there's a basic JSON document:

dput(orderly_location_packit("https://packit.dide.ic.ac.uk/reside/")$client$request("/"))
#> list(status = "success", data = list(schema_version = "0.1.1"), errors = NULL)

Checking the status is good enough. This should work on both packit and outpack_server.

For a path location it should retain the existing root_open behaviour.

[plietar]

As far as I can tell this means there's no more validation of path locations, since the location_path class does not have an authorize method.

[richfitz]

there was, but it was not at all obvious. I've added a verify method which makes this much less weird, though we'll need to add that to the other location types (e.g., ssh) soon too.

[plietar]

Hit the wrong radio button