dts: msm8909-1gb-qrd-skue: add quirky for lenovo-lxf-p5100 #491
Conversation
| qcom,msm-id = <QCOM_ID_MSM8909 0>, | ||
| <QCOM_ID_MSM8909 0x00 0x102 0x00 0x109 0x00 0x113 0x00>; |
There was a problem hiding this comment.
Will this work?
| qcom,msm-id = <QCOM_ID_MSM8909 0>, | |
| <QCOM_ID_MSM8909 0x00 0x102 0x00 0x109 0x00 0x113 0x00>; | |
| qcom,msm-id = <QCOM_ID_MSM8909 0>, <QCOM_ID_MSM8209 0>, | |
| <QCOM_ID_APQ8009 0>, <QCOM_ID_MSM8609 0>; |
https://github.com/msm8916-mainline/lk2nd/blob/main/lk2nd/include/dt-bindings/arm/qcom%2Cids.h#L112
https://github.com/msm8916-mainline/lk2nd/blob/main/lk2nd/include/dt-bindings/arm/qcom%2Cids.h#L119
https://github.com/msm8916-mainline/lk2nd/blob/main/lk2nd/include/dt-bindings/arm/qcom%2Cids.h#L126
There was a problem hiding this comment.
| qcom,msm-id = <QCOM_ID_MSM8909 0>, | |
| <QCOM_ID_MSM8909 0x00 0x102 0x00 0x109 0x00 0x113 0x00>; | |
| qcom,msm-id = <QCOM_ID_MSM8909 0>, | |
| <QCOM_ID_MSM8909 0 QCOM_ID_MSM8209 0 QCOM_ID_APQ8009 0 QCOM_ID_MSM8609 0>; |
|
missclick i will test it later |
| @@ -4,7 +4,12 @@ | |||
| #include <lk2nd.dtsi> | |||
|
|
|||
| / { | |||
| qcom,msm-id = <QCOM_ID_MSM8909 0>; | |||
| //some variant of lxf_p5100 bootloder is quirky and they only select | |||
There was a problem hiding this comment.
I'd appreciate C style comments (/* */)
| @@ -4,7 +4,12 @@ | |||
| #include <lk2nd.dtsi> | |||
|
|
|||
| / { | |||
| qcom,msm-id = <QCOM_ID_MSM8909 0>; | |||
| //some variant of lxf_p5100 bootloder is quirky and they only select | |||
| //<QCOM_ID_MSM8909 0x00 0x102 0x00 0x109 0x00 0x113 0x00> | |||
There was a problem hiding this comment.
As already suggested, please decode those constants to appropriate QCOM_ID and split to two-cell values. Don't think you need to repeat the array twice. I'd also actually appreciate if you can isolate your device to one specific msm-id, not add all of them (i.e. to know if it matches 3g-only 8209 or wifi only 8009)
No description provided.