Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts: msm8909-1gb-qrd-skue: add quirky for lenovo-lxf-p5100 #491

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

dts: msm8909-1gb-qrd-skue: add quirky for lenovo-lxf-p5100 #491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lk2nd/device/dts/msm8909/msm8909-qrd-skue.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,12 @@
#include <lk2nd.dtsi>

/ {
qcom,msm-id = <QCOM_ID_MSM8909 0>;
//some variant of lxf_p5100 bootloder is quirky and they only select
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd appreciate C style comments (/* */)

//<QCOM_ID_MSM8909 0x00 0x102 0x00 0x109 0x00 0x113 0x00>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As already suggested, please decode those constants to appropriate QCOM_ID and split to two-cell values. Don't think you need to repeat the array twice. I'd also actually appreciate if you can isolate your device to one specific msm-id, not add all of them (i.e. to know if it matches 3g-only 8209 or wifi only 8009)

//not <QCOM_ID_MSM8909 0>

qcom,msm-id = <QCOM_ID_MSM8909 0>,
<QCOM_ID_MSM8909 0x00 0x102 0x00 0x109 0x00 0x113 0x00>;
Comment on lines +11 to +12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work?

Suggested change
qcom,msm-id = <QCOM_ID_MSM8909 0>,
<QCOM_ID_MSM8909 0x00 0x102 0x00 0x109 0x00 0x113 0x00>;
qcom,msm-id = <QCOM_ID_MSM8909 0>, <QCOM_ID_MSM8209 0>,
<QCOM_ID_APQ8009 0>, <QCOM_ID_MSM8609 0>;

https://github.com/msm8916-mainline/lk2nd/blob/main/lk2nd/include/dt-bindings/arm/qcom%2Cids.h#L112
https://github.com/msm8916-mainline/lk2nd/blob/main/lk2nd/include/dt-bindings/arm/qcom%2Cids.h#L119
https://github.com/msm8916-mainline/lk2nd/blob/main/lk2nd/include/dt-bindings/arm/qcom%2Cids.h#L126

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that dont work

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
qcom,msm-id = <QCOM_ID_MSM8909 0>,
<QCOM_ID_MSM8909 0x00 0x102 0x00 0x109 0x00 0x113 0x00>;
qcom,msm-id = <QCOM_ID_MSM8909 0>,
<QCOM_ID_MSM8909 0 QCOM_ID_MSM8209 0 QCOM_ID_APQ8009 0 QCOM_ID_MSM8609 0>;

qcom,board-id = <QCOM_BOARD_ID_QRD 0x09>,
<QCOM_BOARD_ID(QRD, 1, 0) 0x09>;
};
Expand Down