Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overwrite flag to upsert json cli #5863

Open
1 of 3 tasks
fergie-nz opened this issue Dec 19, 2024 · 0 comments · May be fixed by #6377
Open
1 of 3 tasks

Add overwrite flag to upsert json cli #5863

fergie-nz opened this issue Dec 19, 2024 · 0 comments · May be fixed by #6377
Assignees
Labels
enhancement New feature or request feature: reports Team Ruru 🦉 Roxy, Ferg, Noel

Comments

@fergie-nz
Copy link
Contributor

fergie-nz commented Dec 19, 2024

Is your feature request related to a problem? Please describe 👀

Reports versioning introduced conditional upserting of reports on server start and with the upsert-reports-json. Ie, if a report already exists, it won't be upserted.

This makes developing reports difficult, as devs will likely want to rapidly upsert the same report many times while testing without bumping the version.

To change this, we want to introduce an -o (overwrite) flag on the upsert-reports-json command. This will force overwrite reports even if they exist already.
Note this was the behaviour of the upsert-reports-json command prior to the report versioning PR.

Also we want to add a pathing package to the upsert-reports-json command when a reports.json file path is specified. Currently it will search compatibly with mac OS. We want this to be flexible to linux or other systems wherever OMS may be running.

Also need a separate CLI command for use on tester's environment which can access embedded standard reports (not looking through file structure).
This would need to overwrite existing reports in the database.

Describe the solution you'd like 🎁|

  • Add -o flag to upsert-reports-json command.
  • Add path package to optional reports json file location.
  • Separate CLI to upsert bundled standard reports which is usable in tester's environment

Describe alternatives you've considered 💭

Additional context 💌

Moneyworks Jobcode 🧰

@andreievg andreievg added the Team Ruru 🦉 Roxy, Ferg, Noel label Jan 28, 2025
@andreievg andreievg changed the title Add functionality to upsert reports json CLI Add overwrite flag to upsert json cli Jan 28, 2025
@EthanMcQ-TMF EthanMcQ-TMF linked a pull request Jan 31, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature: reports Team Ruru 🦉 Roxy, Ferg, Noel
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants