WIP: Refactor #72
Closed
WIP: Refactor #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 14, 2018 11:23
The regression tests that were in the package are now factored out of it.
added 21 commits
February 6, 2018 18:17
Use .git/info/exclude instead.
|
The administration replied negatively. They "do not plan to improve their menues" (paraphrased). However, I noticed that the "old" website has no issues this week (https://web.archive.org/web/20180214151535/http://www.studierendenwerk-aachen.de/speiseplaene/academica-w.html). I will observe the old website. If it proves itself to be stable for the next weeks, I will close this PR and instead rewrite the parser to use the new |
Closed
|
Replaced by #73. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the list menu, I modified Aachen to parse from the table menu. The table is more stable, has less glitches like duplicate entries and weird formatting.
However, currently the table for the Academica does not include certain dishes, namely "Express", "Pizza Classics" and "Ofenkartoffel". This might break for some users, and thus warrants a discussion.
I've already asked the canteen's administration per mail for help with the online menu's inconsistencies, but have not received a reply, yet.
Note that this is a rebase of #70.