Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build cleanups and enforce a subset of tests #19

Merged
merged 12 commits into from
Jul 29, 2021
Merged

Build cleanups and enforce a subset of tests #19

merged 12 commits into from
Jul 29, 2021

Commits on Jul 25, 2021

  1. build: Cleanup ncursesw include lookup code 

    Mirror what si already done for libffi; Look it up via
pkg-config and use the exported path via sysconfig in setup.py

This should be merged into "dont include system ncurses path"
    @lazka
    lazka committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    56b99ee View commit details
    Browse the repository at this point in the history

  2. tests: fix test_bytes 

    %p has different casing with mingw-w64, but it's implementation defined.
Change the test to the mingw-w64 variant.
    @lazka
    lazka committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    d932e3d View commit details
    Browse the repository at this point in the history

  3. time: fix strftime not raising for invalid year values 

    It's crt specific and not compiler specific.
This fixes a test case in test_time
    @lazka
    lazka committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    ce84c05 View commit details
    Browse the repository at this point in the history

  4. winconsoleio: build _testconsole which is required for the tests 

    This fixes test_winconsoleio

Should be merged into "build winconsoleio"
    @lazka
    lazka committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    92f4c9b View commit details
    Browse the repository at this point in the history

  5. Adjust Py_WINVER for our Win 7 target 

    We support win7 still, so adjust accordingly.

Should be merged into the win7 patch
    @lazka
    lazka committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    72b93eb View commit details
    Browse the repository at this point in the history

  6. ctypes: find_library('c') should return None with ucrt 

    Just like with MSVC. This fixes a test in test_ctypes.
    @lazka
    lazka committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    ca15123 View commit details
    Browse the repository at this point in the history

  7. build: Disable checks for dlopen/dlfcn 

    While it is (potentially) available with mingw we don't want to use it, so skip any
checks for it.
    @lazka
    lazka committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    91ea7b2 View commit details
    Browse the repository at this point in the history

  8. Fix install location of the import library

    @lazka
    lazka committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    45f5d2a View commit details
    Browse the repository at this point in the history

  9. Set MSYS2_ARG_CONV_EXCL for the shared Python module install 

    Otherwise one has to set it when calling "make install".
    @lazka
    lazka committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    79691b1 View commit details
    Browse the repository at this point in the history

  10. build: Integrate venvlauncher build/installation into the Makefile 

    This is required for venv creation on Windows.
Ideally this would use the venv specific launcher (PC/launcher.c),
but a copy of main binary seems to work as well for now.
    @lazka
    lazka committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    d2e146a View commit details
    Browse the repository at this point in the history

  11. Update smoketests

    @lazka
    lazka committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    6edeeed View commit details
    Browse the repository at this point in the history

  12. CI: clean up the build; enforce some tests 

    This now enforces success of a subset of tests (see mingw_ignorefile.txt)
and runs smoketests on the build as well as after installation.

Remove everything that is no longer needed after the previous patches:

* the build uses -O3 by default
* it sets fwrapv by default
* __USE_MINGW_ANSI_STDIO is not needed anymore with c99
* it sets_WIN32_WINNT anyway
* ncurses is fixed by patching the build
* debug is handled by autotools
* all ac_cv_* overrides are now handled in configure.ac
* venvlauncher is handled by the main makefile
* setting MSYS2_ARG_CONV_EXCL is now handled by the makefile
* the import library is now installed by the makefile
* _sysconfig_data overrides are handled at runtime anyway
* we don't care about permissions.. (I think?)
    @lazka
    lazka committed Jul 25, 2021
    Configuration menu
    Copy the full SHA
    f4f8270 View commit details
    Browse the repository at this point in the history