Build cleanups and enforce a subset of tests #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirror what si already done for libffi; Look it up via pkg-config and use the exported path via sysconfig in setup.py This should be merged into "dont include system ncurses path"
%p has different casing with mingw-w64, but it's implementation defined. Change the test to the mingw-w64 variant.
It's crt specific and not compiler specific. This fixes a test case in test_time
This fixes test_winconsoleio Should be merged into "build winconsoleio"
We support win7 still, so adjust accordingly. Should be merged into the win7 patch
Just like with MSVC. This fixes a test in test_ctypes.
While it is (potentially) available with mingw we don't want to use it, so skip any checks for it.
Otherwise one has to set it when calling "make install".
This is required for venv creation on Windows. Ideally this would use the venv specific launcher (PC/launcher.c), but a copy of main binary seems to work as well for now.
This now enforces success of a subset of tests (see mingw_ignorefile.txt) and runs smoketests on the build as well as after installation. Remove everything that is no longer needed after the previous patches: * the build uses -O3 by default * it sets fwrapv by default * __USE_MINGW_ANSI_STDIO is not needed anymore with c99 * it sets_WIN32_WINNT anyway * ncurses is fixed by patching the build * debug is handled by autotools * all ac_cv_* overrides are now handled in configure.ac * venvlauncher is handled by the main makefile * setting MSYS2_ARG_CONV_EXCL is now handled by the makefile * the import library is now installed by the makefile * _sysconfig_data overrides are handled at runtime anyway * we don't care about permissions.. (I think?)
This was referenced Jul 25, 2021
Closed
|
I think this also fixed #11 - running smoketests succeeds pre-install, maybe because the import lib is now in the right place? -- oh, or maybe python3.9 is installed and it's using the installed import lib? |
|
hm, it shouldn't have changed because cpython-mingw/.github/workflows/mingw.yml Line 143 in b38e504 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to make the build setup simpler and to run/enforce some tests in CI so we have a higher chance of detecting regressions.
See the commits for details
Fixes #13
Fixes #14
Fixes #17