Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link against ucrt.lib to resolve missing symbols for malloc #82

Closed
wants to merge 1 commit into from

Conversation

Wodann
Copy link
Collaborator

@Wodann Wodann commented Jan 14, 2020

Temporary fix for Windows, as long as we are using malloc.

@Wodann Wodann requested a review from baszalmstra January 14, 2020 16:14
@Wodann Wodann self-assigned this Jan 14, 2020
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #82 into master will decrease coverage by 0.25%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   74.63%   74.37%   -0.26%     
==========================================
  Files         117      117              
  Lines        8893     8894       +1     
==========================================
- Hits         6637     6615      -22     
- Misses       2256     2279      +23
Impacted Files Coverage Δ
crates/mun_codegen/src/code_gen/linker.rs 29.54% <0%> (-6.09%) ⬇️
crates/mun_target/src/spec/windows_msvc_base.rs 0% <0%> (-100%) ⬇️
...ates/mun_target/src/spec/x86_64_pc_windows_msvc.rs 0% <0%> (-100%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a204e63...43eb1ea. Read the comment docs.

@Wodann Wodann force-pushed the fix/malloc branch 8 times, most recently from 12180fa to 6e52a4e Compare January 14, 2020 20:29
@Wodann
Copy link
Collaborator Author

Wodann commented Jan 26, 2020

No longer necessary as PR #90 introduces runtime linked malloc.

@Wodann Wodann closed this Jan 26, 2020
@Wodann Wodann deleted the fix/malloc branch March 25, 2020 11:25
@Wodann Wodann modified the milestones: Mun v0.2, Mun v0.2.0 May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant