proposal: monitor IMA ad events for the user #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daytime-em
force-pushed
the
data-api-proposal
branch
from
c07e8f8
to
0d571df
Compare
cjpillsbury
approved these changes
Oct 29, 2024
|
I just remembered that I need to update the Example in the SPM project. |
cjpillsbury
reviewed
Oct 29, 2024
cjpillsbury
reviewed
Oct 29, 2024
andrewjl-mux
requested changes
Oct 29, 2024
...PluginSPMExampleIOS/MuxStatsGoogleIMAPluginSPMExampleIOS/PlayerContainerViewController.swift
Show resolved
Hide resolved
…MExampleIOS/PlayerContainerViewController.swift Co-authored-by: AJ Lauer Barinov <[email protected]>
|
ok, build fixed! |
andrewjl-mux
approved these changes
Oct 29, 2024
Merged
daytime-em
pushed a commit
that referenced
this pull request
Oct 30, 2024
## Breaking * Reworked the `MuxImaListener` API to improve data accuracy (see below) (#42) ## Improvements: * update Mux Data dependencies * add Swift Package Manager example ### Steps to migrate existing integration 1. Replace calls to `MuxImaLister` with `MUXSDKIMAAdListener`. `MuxImaListener` supports the same new API so this step is optional, the remaining steps are applicable to `MuxImaListener`. As of `v0.14.0`, `MuxImaLister` is deprecated and will be removed in a future release. 2. Supply an `IMAAdsLoader` when calling the `MUXSDKIMAAdListener` initializer. Make sure your IMAAdsLoader delegate **is configured before this step**. 3. MUXSDKIMAAdListener will forward `IMAAdsLoaderDelegate` calls to your delegate. 4. When you've created a new `IMAAdsManager`, like you've done with `IMAAdsLoader`, configure your own `IMAAdsManagerDelegate` first and then call `monitorAdsManager`. 5. MUXSDKIMAAdListener will forward `IMAAdsManagerDelegate` calls to your delegate. 6. Remove calls to `dispatchEvent`, `dispatchError`, and `onContentPauseOrResume` from your integration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the proposed changes.
We need to update the unit tests before we un-draft this