Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate pyupgrade in the pre-commit hooks #1249

Merged
merged 2 commits into from
Jun 30, 2024
Merged

Deactivate pyupgrade in the pre-commit hooks #1249

merged 2 commits into from
Jun 30, 2024

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Jun 30, 2024

Until we figure out what is the problem with tests/external/simple_external_notebooks/test_read_simple_pandoc.py

out what is the problem with
tests/external/simple_external_notebooks/test_read_simple_pandoc.py
Copy link

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

HATCH_BUILD_HOOKS_ENABLE=true pip install git+https://github.com/mwouts/jupytext.git@disable_pyupgrade

(this requires nodejs, see more at Developing Jupytext)

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (fd07ae2) to head (929eec2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
- Coverage   97.76%   97.73%   -0.03%     
==========================================
  Files          29       29              
  Lines        4468     4468              
==========================================
- Hits         4368     4367       -1     
- Misses        100      101       +1     
Flag Coverage Δ
external 75.05% <ø> (-0.10%) ⬇️
functional 88.52% <ø> (ø)
integration 77.28% <ø> (ø)
unit 66.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwouts mwouts merged commit 42a48e8 into main Jun 30, 2024
30 of 32 checks passed
@mwouts mwouts deleted the disable_pyupgrade branch June 30, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant