Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate pyupgrade in the pre-commit hooks #1249

Merged
merged 2 commits into from
Jun 30, 2024
Merged

Deactivate pyupgrade in the pre-commit hooks #1249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b626aca
Deactivate pyupgrade until we figure
mwouts Jun 30, 2024
929eec2
These two tests require myst
mwouts Jun 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,6 @@ repos:
- id: end-of-file-fixer
- id: trailing-whitespace

- repo: https://github.com/asottile/pyupgrade
rev: v3.15.0
hooks:
- id: pyupgrade
args: ["--py38-plus"]

- repo: https://github.com/PyCQA/isort
rev: 5.12.0
hooks:
Expand Down
4 changes: 4 additions & 0 deletions tests/functional/round_trip/test_myst_header.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
import pytest

from jupytext import reads, writes
from jupytext.compare import compare
from jupytext.config import load_jupytext_configuration_file


@pytest.mark.requires_myst
def test_myst_header_is_stable_1247_using_inline_filter(
md="""---
jupytext:
Expand All @@ -29,6 +32,7 @@ def test_myst_header_is_stable_1247_using_inline_filter(
compare(md2, md)


@pytest.mark.requires_myst
def test_myst_header_is_stable_1247_using_config(
jupytext_toml_content="""notebook_metadata_filter = "-jupytext.text_representation.jupytext_version,settings,mystnb"
""",
Expand Down
Loading