Document roles and configuration parameters #287
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe instead of calling fee receiver call it primary fee receiver. This way when people bring up fee receiver they are forced to specify which one so its more clear. |
Paul4912
reviewed
Dec 15, 2021
|
|
||
| These are the configurable parameters of an individual pool: | ||
|
|
||
| | Name | Type | Deployment Only? | Who? | Description | |
There was a problem hiding this comment.
Think you should specify Deployment only? means that they cannot be modified adhoc post deployment. Might be not obvious to non technical readers.
Paul4912
reviewed
Dec 16, 2021
|
|
||
| | Name | Type | Deployment Only? | Who? | Description | | ||
| | --- | --- | --- | --- | --- | | ||
| | Oracle | `address` | True | Deployer | Address of the associated Chainlink oracle to wrap | |
There was a problem hiding this comment.
think you shud add deployer address as param.
Its an important param that the factory only allows pools to be deployed from same deployer
and you can also set it as another address when creating oraclewrappers, not neccesarily default the deployer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #279
Changes
docsdirectory