-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document roles and configuration parameters #287
Draft
sporejack
wants to merge
4
commits into
pools-v2
Choose a base branch
from
279-roles-config-doc
base: pools-v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
# Configuring Perpetual Pools # | ||
|
||
Any given instance of a Perpetual Pools deployment consists of various | ||
parameters that govern various aspects of the system's behaviour. Broadly, these | ||
are divisible into two categories: factory parameters and pool parameters. The | ||
latter category consists of the parameters responsible for a given pool and thus | ||
do not affect the values of the former category. | ||
|
||
## Roles ## | ||
|
||
These are the *externally-facing* roles in an instance of a Perpetual Pools | ||
system: | ||
|
||
| Name | Description | | ||
| --- | --- | | ||
| Fee receiver | TODO | | ||
| Secondary fee receiver | TODO | | ||
| Factory owner | TODO | | ||
| Pool owner | TODO | | ||
|
||
## Parameters ## | ||
|
||
### Pools ### | ||
|
||
These are the configurable parameters of an individual pool: | ||
|
||
| Name | Type | Deployment Only? | Who? | Description | | ||
| --- | --- | --- | --- | --- | | ||
| Pool Governor | `address` | False | Pool Governor | Essentially the owner of the pool | | ||
| Secondary Fee Receiver | `address` | False | Secondary fee receiver | Receipient of secondary fee revenue | | ||
| Fee Receiver | `address` | False | Pool Governor | Receipient of primary fee revenue | | ||
| Oracle Wrapper | `address` | True | Deployer | TODO | | ||
| Settlement ETH Oracle | `address` | True | Deployer | TODO | | ||
| Long Token | `address` | True | Deployer | TODO | | ||
| Short Token | `address` | True | Deployer | TODO | | ||
| Pool Committer | `address` | True | Deployer | TODO | | ||
| Invariant Checker | `address` | True | Deployer | TODO | | ||
| Pool Name | `string` | True | Deployer | TODO | | ||
| Frontrunning Interval | `uint32` | True | Deployer | TODO | | ||
| Update Interval | `uint32` | True | Deployer | TODO | | ||
| Leverage | `uint16` | True | Deployer | TODO | | ||
| Fee | `uint256` | True | Deployer | TODO | | ||
| Quote Token | `address` | True | Depoyer | TODO | | ||
|
||
### Factory ### | ||
|
||
| Name | Type | Deployment Only? | Who? | Description | | ||
| --- | --- | --- | --- | --- | | ||
| Factory Owner | `address` | False | Factory Owner | TODO | | ||
| Mint/Burn Fee | `uint256` | False | Factory Owner | TODO | | ||
| Primary Fee | `uint256` | False | Factory Owner | TODO | | ||
| Secondary Fee | `uint256` | False | Factory Owner | TODO | | ||
| Maximum Leverage | `uint256` | False | Factory Owner | TODO | | ||
| Autoclaimer | `address` | False | Factory Owner | TODO | | ||
| Pool Keeper | `address` | False | Factory Owner | TODO | | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think you should specify Deployment only? means that they cannot be modified adhoc post deployment. Might be not obvious to non technical readers.