Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webhooks): link shipment to order #327

Merged

Conversation

joerivanveen
Copy link
Contributor

@joerivanveen joerivanveen commented Dec 5, 2024

Allows showing shipment details including barcode in order mode, when label is printed in backoffice.

INT-627

@joerivanveen joerivanveen changed the title fix(ordermode): show barcode when printed from backoffice fix(ordermode)!: show barcode when printed from backoffice Dec 5, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.69%. Comparing base (bd685ff) to head (5f869e2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #327   +/-   ##
=========================================
  Coverage     96.68%   96.69%           
- Complexity     1716     1721    +5     
=========================================
  Files           319      319           
  Lines          5820     5835   +15     
=========================================
+ Hits           5627     5642   +15     
  Misses          193      193           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joerivanveen joerivanveen changed the title fix(ordermode)!: show barcode when printed from backoffice fix(ordermode): show barcode when printed from backoffice Dec 10, 2024
@joerivanveen joerivanveen force-pushed the fix/ordermode/show-barcode-when-printed-from-backoffice branch 2 times, most recently from ad191e7 to ad6cb92 Compare December 10, 2024 15:49
@joerivanveen joerivanveen marked this pull request as ready for review December 10, 2024 15:56
@joerivanveen joerivanveen requested a review from a team as a code owner December 10, 2024 15:56
@myparcel-bot myparcel-bot bot added the changes requested (Auto) label Dec 11, 2024
@FreekVR
Copy link
Contributor

FreekVR commented Dec 11, 2024

Commit message covers the end-user feature but not really the changes in this repo.

Suggest to change it to (as I understand these changes, please correct if not right)

feat: improved linking shipments to orders

allows showing barcode when printed from backoffice #327

@joerivanveen joerivanveen changed the title fix(ordermode): show barcode when printed from backoffice feat(webhooks): link shipment to order Dec 11, 2024
@myparcel-bot myparcel-bot bot removed the changes requested (Auto) label Dec 16, 2024
@myparcel-bot myparcel-bot bot added the approved (Auto) label Dec 16, 2024
@CherMyParcel CherMyParcel added this pull request to the merge queue Dec 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 16, 2024
@myparcel-bot myparcel-bot bot force-pushed the fix/ordermode/show-barcode-when-printed-from-backoffice branch from d54b1f1 to 5f869e2 Compare December 17, 2024 08:09
@CherMyParcel CherMyParcel added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit e61fc9d Dec 17, 2024
8 checks passed
@CherMyParcel CherMyParcel deleted the fix/ordermode/show-barcode-when-printed-from-backoffice branch December 17, 2024 08:50
myparcel-bot bot added a commit that referenced this pull request Dec 17, 2024
## [2.48.0](v2.47.2...v2.48.0) (2024-12-17)

### ✨ New Features

* **webhooks:** link shipment to order ([#327](#327)) ([e61fc9d](e61fc9d))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Dec 17, 2024

🎉 This PR is included in version 2.48.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants