Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add receiptCode to test responses #289

Closed
wants to merge 1 commit into from

Conversation

FreekVR
Copy link
Collaborator

@FreekVR FreekVR commented Nov 22, 2024

adds empty/inherited receiptCode to expected responses to support recent PDK updates

fixes INT-736

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.31%. Comparing base (351c375) to head (abd2320).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #289   +/-   ##
=========================================
  Coverage     49.31%   49.31%           
  Complexity      602      602           
=========================================
  Files           151      151           
  Lines          3897     3897           
  Branches         55       55           
=========================================
  Hits           1922     1922           
  Misses         1920     1920           
  Partials         55       55           
Flag Coverage Δ
backend 76.97% <ø> (ø)
frontend 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Nov 22, 2024

PDK upgrade summary

♻️ The following packages were upgraded (from cache):

Package Old version New version
@myparcel-pdk/admin 1.5.3 1.5.4
@myparcel-pdk/admin-component-tests 1.5.3 1.5.4
@myparcel-pdk/admin-preset-bootstrap4 1.5.3 1.5.4
@myparcel-pdk/admin-preset-default 1.5.3 1.5.4
@myparcel-pdk/app-builder 1.6.0 1.6.1
myparcelnl/pdk 2.47.1 2.47.2

adds empty/inherited receiptCode to expected responses to support recent PDK updates
@FreekVR FreekVR force-pushed the fix/add-receipt-code-to-test-responses branch from 0b8e351 to abd2320 Compare November 22, 2024 11:13
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Nov 22, 2024

✅ Build successful!

You can find a link to the downloadable artifact below.

Name Link
Commit abd2320
Logs https://github.com/myparcelnl/prestashop/actions/runs/11971512382
Download https://github.com/myparcelnl/prestashop/suites/31211374109/artifacts/2223831375

@FreekVR
Copy link
Collaborator Author

FreekVR commented Nov 25, 2024

Was fixed directly on main after this PR was opened, so closing as redunant now.

@FreekVR FreekVR closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants