Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore OMF-5 backward compatibility #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shtrom
Copy link
Member

@shtrom shtrom commented Sep 23, 2014

  • Map old bindProperty to setProperty, and issue a warning that it is deprecated;
  • Don't complain about 'version' is deprecated and not supported;
  • Use path instead of bin_path;

fixes: #1804

http://oml.mytestbed.net/issues/1804

Signed-off-by: Olivier Mehani [email protected]

* Map old bindProperty to setProperty, and issue a warning that it is deprecated;
* Don't complain about 'version' is deprecated and not supported;
* Use path instead of bin_path;

fixes: #1804

Signed-off-by: Olivier Mehani <[email protected]>
@@ -24,6 +24,11 @@ def initialize(name, group)
end
end

def bindProperty(key, property_value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually bindProperty is now supported in OMF 6. From my understanding, and from the example in http://oml.mytestbed.net/issues/1804, it is related to Prototype... which has been ported into 6. The definition of bindProperty is at omf_ec/lib/omf_ec/context/app_context.rb +115 under commit 77bad4d.

May I suggest NOT map bindProperty to setProperty for now, and assume that bindProperty is used for Prototype only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants