Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore OMF-5 backward compatibility #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Restore OMF-5 backward compatibility #11

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67a33f2
Restore OMF-5 backward compatibility
shtrom Sep 23, 2014
8b16913
Partial revert of 67a33f2 for bindProperty
shtrom Oct 9, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions omf_ec/lib/omf_ec/app_definition.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,8 @@ def define_measurement_point(mp)
end
end

warn_removed :version

def path=(arg)
@properties[:binary_path] = arg
warn_deprecation :path=, :binary_path=
end

def shortDescription=(arg)
Expand Down
5 changes: 5 additions & 0 deletions omf_ec/lib/omf_ec/context/app_context.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ def initialize(name, group)
end
end

def bindProperty(key, property_value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually bindProperty is now supported in OMF 6. From my understanding, and from the example in http://oml.mytestbed.net/issues/1804, it is related to Prototype... which has been ported into 6. The definition of bindProperty is at omf_ec/lib/omf_ec/context/app_context.rb +115 under commit 77bad4d.

May I suggest NOT map bindProperty to setProperty for now, and assume that bindProperty is used for Prototype only.

warn_deprecation :bindProperty, :setProperty
setProperty(key, property_value)
end

def setProperty(key, property_value)
app_def_param = app_def.properties.parameters
raise OEDLUnknownProperty.new(key, "Unknown parameter '#{key}' for application "+
Expand Down