Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show error when signing in with unregistered email #299

Merged
merged 5 commits into from
Dec 22, 2024
Merged

fix: Show error when signing in with unregistered email #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3def82a
Fix: Display error message for unregistered email on sign-in
nakul-py Dec 19, 2024
dee1a26
adding requested changes
nakul-py Dec 20, 2024
4b37e15
adding changeset to pr
nakul-py Dec 20, 2024
0180c37
Completing the requested changes
nakul-py Dec 21, 2024
fa90cdf
Removing console.error
nakul-py Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/polite-monkeys-travel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"namesake": minor
---

fix: Show error when signing in with unregistered email
nakul-py marked this conversation as resolved.
Show resolved Hide resolved
29 changes: 15 additions & 14 deletions src/routes/_unauthenticated/signin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,25 +44,26 @@ const SignIn = () => {
setIsSubmitting(true);
setError(null);

await signIn("password", {
flow,
email,
password,
redirectTo: "/quests",
})
.catch((error) =>
error instanceof ConvexError
? setError(error.message)
: setError(error),
)
.then(() => navigate({ to: "/" }))
.finally(() => setIsSubmitting(false));
try {
await signIn("password", {
flow,
email,
password,
redirectTo: "/quests",
});
navigate({ to: "/" });
} catch (error) {
setError("Couldn't sign in. Check your information and try again.");
} finally {
setIsSubmitting(false);
}
};

if (flow === "reset")
if (flow === "reset") {
return (
<ForgotPassword onBack={() => setFlow("signIn")} defaultEmail={email} />
);
}

return (
<Tabs selectedKey={flow} onSelectionChange={setFlow}>
Expand Down
Loading