-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Show error when signing in with unregistered email #299
Conversation
🦋 Changeset detectedLatest commit: fa90cdf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nakul-py! In order to display the error here, we'll need to update the sign in logic on the backend.
You can look at the Convex Auth docs for email validation for more info: https://labs.convex.dev/auth/config/passwords#email-address-validation
Note you'll also need to add a changeset to this PR! You can do it from the command line with |
The output :- Screencast.from.2024-12-21.17-56-13.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny change, otherwise looks good! Thanks so much, @nakul-py!
This commit will close this issue fa90cdf |
Thanks so much @nakul-py! 💟 |
What changed?
Why?
Screencast:
Screencast.from.2024-12-21.17-56-13.mp4