Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show error when signing in with unregistered email #299

Merged
merged 5 commits into from
Dec 22, 2024

Conversation

nakul-py
Copy link
Contributor

@nakul-py nakul-py commented Dec 19, 2024

What changed?

Why?

  • This change was implemented to improve the user experience by notifying users immediately when they attempt to sign in with an unregistered email.
  • Users no longer need to guess why they can't log in or be confused by no feedback, leading to better usability and fewer failed attempts.

Screencast:

Screencast.from.2024-12-21.17-56-13.mp4

Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: fa90cdf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
namesake Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the frontend CSS, HTML, and JS changes label Dec 19, 2024
Copy link
Member

@evadecker evadecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nakul-py! In order to display the error here, we'll need to update the sign in logic on the backend.

You can look at the Convex Auth docs for email validation for more info: https://labs.convex.dev/auth/config/passwords#email-address-validation

src/routes/_unauthenticated/signin.tsx Outdated Show resolved Hide resolved
src/routes/_unauthenticated/signin.tsx Outdated Show resolved Hide resolved
@evadecker evadecker changed the title Fix: Display error message for unregistered email on sign-in page. fix: Show error when signing in with unregistered email Dec 19, 2024
@evadecker
Copy link
Member

Note you'll also need to add a changeset to this PR! You can do it from the command line with pnpm changeset.

@nakul-py nakul-py requested a review from evadecker December 20, 2024 14:26
.changeset/polite-monkeys-travel.md Show resolved Hide resolved
src/routes/_unauthenticated/signin.tsx Outdated Show resolved Hide resolved
src/routes/_unauthenticated/signin.tsx Outdated Show resolved Hide resolved
src/routes/_unauthenticated/signin.tsx Outdated Show resolved Hide resolved
@evadecker evadecker linked an issue Dec 21, 2024 that may be closed by this pull request
@nakul-py
Copy link
Contributor Author

The output :-

Screencast.from.2024-12-21.17-56-13.mp4

@nakul-py nakul-py requested a review from evadecker December 21, 2024 12:57
Copy link
Member

@evadecker evadecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change, otherwise looks good! Thanks so much, @nakul-py!

src/routes/_unauthenticated/signin.tsx Outdated Show resolved Hide resolved
@nakul-py
Copy link
Contributor Author

This commit will close this issue fa90cdf

@evadecker evadecker merged commit e4a7813 into namesakefyi:main Dec 22, 2024
7 checks passed
@evadecker
Copy link
Member

Thanks so much @nakul-py! 💟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend CSS, HTML, and JS changes
Projects
None yet
2 participants