Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake build system for cfl3d #5

Open
wants to merge 65 commits into
base: master
Choose a base branch
from
Open

CMake build system for cfl3d #5

wants to merge 65 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 10, 2017

In order to make build system more robust and parallel. I replaced it with CMake build system. And I just merged it with the newest nasa/cfl3d. I just checked the comparison of files modified:

  • build directory is purged, all makefile_cpp and makefile, Install, makefile_xx_examples are removed.
  • add a build/bin/create_use_cfl3d to add alias use_cfl3d="export PATH='\$HOME/cfl3d/CFL3D/build/bin:\$PATH'"
  • cputim.F is modified to be compatible with gcc/gfortran
  • spalart.F is modified to solve complex version problem.
  • a lot of CMakeLists.txt are added to create the cmake build system..

Now you only need

cd CFL3D/build
cmake ..
make -j`nproc`

That's all.

Di Cheng added 26 commits August 11, 2017 01:28
Modify a bug in alias use_cfl3d: 在\$PATH前添加\\,避免其在使用前展开。
@crumsey
Copy link
Collaborator

crumsey commented Nov 28, 2017

Cmake build system is a great idea, but currently we want to keep the original way as well. So it would be nice to have it as an optional addition, without removal of the old style. Also, best if commits are kept simpler (not so many changes in the same commit)... makes it much easier to adopt them wholesale. We do not want to include CGNS library here, nor files from the TMR website... those are kept independently. Thanks for finding the minor issues; many have been implemented independently.

@weijianwen
Copy link

This PR seems duplicate with #4 with some irrelevant chages regarding to adopting CMake. I recommend to keep things as they are if they are not obstacles for CMake. Better one commit for doing one thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants