Auto-unlock if save_locked_judgment_xml fails and unlock was requested #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragon-dxw
force-pushed
the
feature/unlock-on-fail
branch
from
f715927 to
2b69ebb
Compare
CristinaRO
approved these changes
Apr 10, 2024
| # More generally testing errors are passed through from the client | ||
| mocked_client.return_value.save_locked_judgment_xml.side_effect = Mock( | ||
| side_effect=MarklogicResourceLockedError(), | ||
| ) |
There was a problem hiding this comment.
Might be worth adding a newline, to have the arrange - act - assert separation clearer.
dragon-dxw
force-pushed
the
feature/unlock-on-fail
branch
2 times, most recently
from
0af4ba7 to
8a740cd
Compare
dragon-dxw
force-pushed
the
feature/unlock-on-fail
branch
from
8a740cd to
15e81ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enrichment process has hit a significant error when trying to upload (it's probably not schema-valid) so if it asked to unlock, we should unlock.