Initial strict runtime check #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naucke
force-pushed
the
strict-runtime-check
branch
4 times, most recently
from
04b3068
to
b9766ab
Compare
naucke
force-pushed
the
strict-runtime-check
branch
2 times, most recently
from
5660e9d
to
f77dab2
Compare
naucke
commented
Apr 18, 2024
naucke
force-pushed
the
strict-runtime-check
branch
from
f77dab2
to
707b6ff
Compare
naucke
force-pushed
the
strict-runtime-check
branch
2 times, most recently
from
7e1538c
to
2a23e3e
Compare
naucke
force-pushed
the
strict-runtime-check
branch
from
2a23e3e
to
2c2b929
Compare
naucke
force-pushed
the
strict-runtime-check
branch
3 times, most recently
from
11e3036
to
c03d966
Compare
naucke
force-pushed
the
strict-runtime-check
branch
from
c03d966
to
f98da86
Compare
naucke
force-pushed
the
changes-already-proposed
branch
from
3adb92c
to
03a4c69
Compare
naucke
force-pushed
the
strict-runtime-check
branch
from
f98da86
to
36e4fda
Compare
naucke
force-pushed
the
changes-already-proposed
branch
from
03a4c69
to
5926f94
Compare
naucke
force-pushed
the
strict-runtime-check
branch
2 times, most recently
from
58c8063
to
0329c7a
Compare
jespercockx
reviewed
Jun 4, 2024
There was a problem hiding this comment.
Please find some of my comments on this PR below. I think it's a great addition, however it also adds quite a bit extra complexity to different parts of the agda2hs code base. So it would be great to have the opinion of some others (maybe @omelkonian and @UlfNorell) to hear whether they think this is something worth adding (and continue supporting in the future).
naucke
force-pushed
the
strict-runtime-check
branch
2 times, most recently
from
f207cda
to
4199f37
Compare
naucke
force-pushed
the
strict-runtime-check
branch
2 times, most recently
from
b79784f
to
eb67b28
Compare
naucke
force-pushed
the
strict-runtime-check
branch
from
eb67b28
to
c88c844
Compare
…artial type applications
The types a and b do not appear in Haskell code, so they should be marked as erased
…ated Haskell code
naucke
force-pushed
the
strict-runtime-check
branch
7 times, most recently
from
2f98c9a
to
5f1883b
Compare
naucke
force-pushed
the
strict-runtime-check
branch
2 times, most recently
from
b340b57
to
7db8273
Compare
naucke
force-pushed
the
strict-runtime-check
branch
from
7db8273
to
205a5df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.