fix: 🐛 Match the UI and API path for NotificationSource -> source #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API endpoint for notificationsource should be changed to source
chadell
requested review from
glennmatthews,
pke11y and
scetron
as code owners
|
Since this is a breaking change should we bump the pyproject.toml version so that when the next release is prepped for this project we don't forget to bump the major version? |
gsnider2195
reviewed
Sep 26, 2024
gsnider2195
approved these changes
Sep 26, 2024
This was referenced Sep 27, 2024
Co-authored-by: Gary Snider <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change: API endpoint for notificationsource should be changed to source
Related to #313