[Issue #74]: Pa11y API setup #99
Conversation
btabaska
requested review from
aplybeah,
coilysiren,
andycochran and
acouch
as code owners
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 83.87% | 879/1048 |
| 🟡 | Branches | 68.25% | 230/337 |
| 🟡 | Functions | 76.11% | 172/226 |
| 🟢 | Lines | 83.45% | 827/991 |
Test suite run success
175 tests passing in 57 suites.
Report generated by 🧪jest coverage report action from 79ba97e
| run: | | ||
| cd ../api | ||
| make init db-seed-local start & | ||
| cd ..frontend |
There was a problem hiding this comment.
do we need cd ../frontend with a slash - I think that's the only different b/w this workflow step and the one on ci-frontend-e2e.yml
There was a problem hiding this comment.
There is no functional difference between ..frontend and ../frontend. Up to you if you want that semantic change
There was a problem hiding this comment.
This was causing an issue and you were right. No difference in fish shell, likely a difference in our CI/CD pipeline. My mistake
| @@ -8,6 +8,9 @@ | |||
| "ignoreHTTPSErrors": true, | |||
| "args": ["--disable-dev-shm-usage", "--no-sandbox"] | |||
| }, | |||
| "headers": { | |||
| "Cookie": "_ff={%22showSearchV0%22:true}" | |||
| }, | |||
There was a problem hiding this comment.
Cool - does this work? If it's possible to pause the execution on the search test showing that we're actually getting the search page with all the results - that would be good.
There was a problem hiding this comment.
This is actually the only way that it works. The idea we had of going to the FF page and clicking didn't work because it would execute on every loop and cause the test to stay on the FF page.
The last page we go to is the search page, which has all the results. You can verify it on this branch. it will be the last saved screenshot with all the tests. I attached a screenshot to this PR.
There was a problem hiding this comment.
Ah I see it's just a link in the description - cool looks good!
| @@ -8,6 +8,9 @@ | |||
| "ignoreHTTPSErrors": true, | |||
| "args": ["--disable-dev-shm-usage", "--no-sandbox"] | |||
| }, | |||
| "headers": { | |||
| "Cookie": "_ff={%22showSearchV0%22:true}" | |||
| }, | |||
| @@ -8,6 +8,9 @@ | |||
| "ignoreHTTPSErrors": true, | |||
| "args": ["--disable-dev-shm-usage", "--no-sandbox"] | |||
| }, | |||
| "headers": { | |||
| "Cookie": "_ff={%22showSearchV0%22:true}" | |||
| }, | |||
There was a problem hiding this comment.
Ah I see it's just a link in the description - cool looks good!
|
nit: You might link the issue properly in the PR description |
Fixes #{74}
> Added API setup to PA11y
> Updated Pa11y runtime to enable FF for search
> FF requirement was discovered with Ryan while exploring feature. Will
enable the search page for proper testing
> • svg elements with an img role have an alternative text
(https://dequeuniversity.com/rules/axe/4.2/svg-img-alt?application=axeAPI)
(html)
<html lang="en"><head><meta charset="utf-8"><me...</html>
• svg elements with an img role have an alternative text
(https://dequeuniversity.com/rules/axe/4.2/svg-img-alt?application=axeAPI)
(html)
<html lang="en"><head><meta charset="utf-8"><me...</html>
>Two new errors found now that API results are loading.
Fixes #{74}
> Added API setup to PA11y
> Updated Pa11y runtime to enable FF for search
> FF requirement was discovered with Ryan while exploring feature. Will
enable the search page for proper testing
> • svg elements with an img role have an alternative text
(https://dequeuniversity.com/rules/axe/4.2/svg-img-alt?application=axeAPI)
(html)
<html lang="en"><head><meta charset="utf-8"><me...</html>
• svg elements with an img role have an alternative text
(https://dequeuniversity.com/rules/axe/4.2/svg-img-alt?application=axeAPI)
(html)
<html lang="en"><head><meta charset="utf-8"><me...</html>
>Two new errors found now that API results are loading.
Fixes #{74}
> Added API setup to PA11y
> Updated Pa11y runtime to enable FF for search
> FF requirement was discovered with Ryan while exploring feature. Will
enable the search page for proper testing
> • svg elements with an img role have an alternative text
(https://dequeuniversity.com/rules/axe/4.2/svg-img-alt?application=axeAPI)
(html)
<html lang="en"><head><meta charset="utf-8"><me...</html>
• svg elements with an img role have an alternative text
(https://dequeuniversity.com/rules/axe/4.2/svg-img-alt?application=axeAPI)
(html)
<html lang="en"><head><meta charset="utf-8"><me...</html>
>Two new errors found now that API results are loading.
Summary
Fixes #{74}
Time to review: 3 mins
Changes proposed
Context for reviewers
(html)
• svg elements with an img role have an alternative text (https://dequeuniversity.com/rules/axe/4.2/svg-img-alt?application=axeAPI)
(html)
## Additional information >Two new errors found now that API results are loading. 