Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

[Issue #74]: Pa11y API setup #99

Merged
merged 3 commits into from
Jun 21, 2024
Merged

[Issue #74]: Pa11y API setup #99

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
235fff7
initial commit
btabaska Jun 18, 2024
c3bb360
adding changes to pa11y.json files
btabaska Jun 20, 2024
79ba97e
fixing small typo
btabaska Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/ci-frontend-a11y.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,16 @@ jobs:
- name: Start server and log output
run: npm run start &

- name: Start API Server for search results
run: |
cd ../api
make init db-seed-local start &
cd ..frontend
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need cd ../frontend with a slash - I think that's the only different b/w this workflow step and the one on ci-frontend-e2e.yml

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no functional difference between ..frontend and ../frontend. Up to you if you want that semantic change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing an issue and you were right. No difference in fish shell, likely a difference in our CI/CD pipeline. My mistake

# ensure the API wait script is executable
chmod +x ../api/bin/wait-for-api.sh
../api/bin/wait-for-api.sh
shell: bash

- name: Wait for frontend to be ready
run: |
# Ensure the server wait script is executable
Expand Down
3 changes: 3 additions & 0 deletions frontend/.pa11yci-desktop.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"ignoreHTTPSErrors": true,
"args": ["--disable-dev-shm-usage", "--no-sandbox"]
},
"headers": {
"Cookie": "_ff={%22showSearchV0%22:true}"
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool - does this work? If it's possible to pause the execution on the search test showing that we're actually getting the search page with all the results - that would be good.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually the only way that it works. The idea we had of going to the FF page and clicking didn't work because it would execute on every loop and cause the test to stay on the FF page.

The last page we go to is the search page, which has all the results. You can verify it on this branch. it will be the last saved screenshot with all the tests. I attached a screenshot to this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see it's just a link in the description - cool looks good!

"actions": [
"wait for element #main-content to be visible",
"screen capture screenshots-output/desktop-main-view.png"
Expand Down
3 changes: 3 additions & 0 deletions frontend/.pa11yci-mobile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"ignoreHTTPSErrors": true,
"args": ["--disable-dev-shm-usage", "--no-sandbox"]
},
"headers": {
"Cookie": "_ff={%22showSearchV0%22:true}"
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

"viewport": {
"width": 390,
"height": 844,
Expand Down
Loading