-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Long Quote Block in LiveResource #659
Conversation
@Flo0807 I changed a few internal function with theoretically could be used from the outside. The chance is relatively small... should we add it to the upgrade guide? |
I'd say yes, but we don't have to explain every change in detail. @pehbehbeh |
Co-authored-by: Florian Arens <[email protected]>
see https://hexdocs.pm/credo/Credo.Check.Refactor.LongQuoteBlocks.html
Backpex.LiveResource
Backpex.LiveResource.schema/0
function; see 709bff8Backpex.LiveResource.can?/4
helper; see 9bdd735 and a474210get_filter_options
function; see 2a43e79